Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apps name misalignment in case of no icons #30356

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix: apps name misalignment in case of no icons #30356

merged 3 commits into from
Sep 12, 2023

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Sep 11, 2023 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

  • If there is no icon in the App name, the names were misaligned without indentation.
  • This PR introduces a gap, in place of the missing icon, to have them properly aligned.

After the changes:
image

Issue(s)

Steps to test or reproduce

Further comments

AECO-309

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7fc9cfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #30356 (7fc9cfa) into develop (b58aee7) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30356      +/-   ##
===========================================
- Coverage    50.15%   50.05%   -0.10%     
===========================================
  Files          781      781              
  Lines        14520    14520              
  Branches      2627     2623       -4     
===========================================
- Hits          7282     7268      -14     
+ Misses        6840     6837       -3     
- Partials       398      415      +17
Flag Coverage Δ
e2e 48.46% <ø> (-0.11%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Dnouv Dnouv marked this pull request as ready for review September 11, 2023 19:36
@Dnouv Dnouv requested a review from a team as a code owner September 11, 2023 19:36
@tiagoevanp tiagoevanp added this to the 6.5.0 milestone Sep 11, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2023
@kodiakhq kodiakhq bot merged commit 1000b9b into develop Sep 12, 2023
@kodiakhq kodiakhq bot deleted the fix/appiconalignment branch September 12, 2023 14:57
@casalsgh casalsgh modified the milestones: 6.5.0, 6.4.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoevanp tiagoevanp tiagoevanp approved these changes

Assignees
No one assigned
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Dnouv @tiagoevanp @casalsgh @janainaCoelhoRocketchat